fix(permissions): Pipeline permissions do not affect manual triggers #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation page for Pipeline Permissions explains that when roles are added to a pipeline definition, only users with all of these roles can then edit or execute the pipeline. This is true about edits, since adding a privileged role there would let a user trigger an execution with privileges they don't have, but this feature does not affect manual executions. These still run with the roles and privileges of the user who triggered the pipeline manually, regardless of Pipeline Permissions.
jasonmcintosh
approved these changes
Oct 28, 2024
| user per pipeline). This can potentially remove some users ability to edit affected pipelines. |
There was a problem hiding this comment.
to edit the affected pipelines. minor tweak please.
There was a problem hiding this comment.
I added another "the", from
remove some users ability to edit affected pipelines.
to
remove some users the ability to edit the affected pipelines.
|
Rebased + added the grammar fix suggested here. |
jasonmcintosh
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation page for Pipeline Permissions explains that when roles are added to a pipeline definition, only users with all of these roles can then edit or execute the pipeline. This is true about edits, since adding a privileged role there would let a user trigger an execution with privileges they don't have, but this feature does not affect manual executions. These still run with the roles and privileges of the user who triggered the pipeline manually, regardless of Pipeline Permissions.